Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expand synthesis options, initial state elements in cli #604

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: expand synthesis options, initial state elements in cli #604

wants to merge 14 commits into from
+183 −48

Conversation

donn
Copy link
Member

@donn donn commented Nov 25, 2024 •
edited
Loading

  • Yosys.*Synthesis

    • Created new variable SYNTH_HIERARCHY_MODE, replacing SYNTH_NO_FLAT. There are three options, flatten, deferred_flatten and keep. The first two correspond to SYNTH_NO_FLAT being false and true respectively. The third keeps the hierarchy in the final netlist.
    • Created new variable SYNTH_TIE_UNDEFINED to customize whether undefined and undriven values are tied low, high, or left as-is.
    • Created new variable SYNTH_WRITE_NOATTR to allow attributes to be propagated to the final netlist.

  • Created Yosys.Resynthesis

    • Like Yosys.Synthesis, but uses the current input state netlist as an input instead of RTL files

CLI

  • Added new option: -e/--initial-state-element-override: allows an element in the initial state to be overridden straight from the commandline.

While this is unorthodox, this will be release 2.3.0. The reasoning for this is that these options are critical for an on-going tapeout process.

@openlane-bot
Copy link
Collaborator

openlane-bot commented Nov 25, 2024 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch main --table-verbosity ALL --table-out ./tables_all.md.

  • Changes to critical metrics were detected in the following designs:
    • gf180mcuD/gf180mcu_fd_sc_mcu7t5v0/usb_cdc_core

Full tables ► https://gist.github.com/openlane-bot/7429b86fcf3cec4d7d300816e9cfe1e4

@donn donn marked this pull request as ready for review December 1, 2024 14:51
kareefardi
kareefardi reviewed Dec 1, 2024
View reviewed changes
flake.nix Show resolved Hide resolved
kareefardi
kareefardi reviewed Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@kareefardi kareefardi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is SYNTH_HIERARCHY_MODE keep implicitly used in the source code by it being both config["SYNTH_HIERARCHY_MODE"] == "flatten" and config["SYNTH_HIERARCHY_MODE"] == "defered_flatten" evaluated to false?

@donn
Copy link
Member Author

donn commented Dec 1, 2024

@kareefardi Basically.

@donn donn requested a review from kareefardi December 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi Awaiting requested review from kareefardi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donn @openlane-bot @kareefardi